parser: add a pretty printer for top-level json documents#43702
Merged
Conversation
|
6819856 to
167efe8
Compare
TimvdLippe
requested changes
Apr 4, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Reviewed this PR and had several suggestions. Then I figured it's easier if I open a PR directly on your fork that you can integrate: webbeef#5
Signed-off-by: webbeef <me@webbeef.org>
Several improvements: 1. Define helper functions at the top 2. Add initial DOM nodes, so that we don't need to manually create them and thrash the initial DOM (especially for large JSON documents) 3. Use `classList` for class toggling 4. Use css nesting for shorter CSS code 5. Use `const` instead of `let` Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> Signed-off-by: webbeef <me@webbeef.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new resource implementing a simple pretty printer for json documents.
Testing: build this branch and launch with
./mach run https://httpbin.org/json