Thanks! You are missing a call to ./mach fmt but everything else looks good :)

I must have missed it due to several commits I had to do as a result of merged PRs

Hi @eerii, can you please check what's failing this time?

I ran the /mach fmt already and something is still failing it seems

Hi @eerii, can you please check what's failing this time?

I ran the /mach fmt already and something is still failing it seems

You need to run format again:

+        let browsing_context_actor = self
+            .registry
+            .find::<BrowsingContextActor>(browsing_context_name);
+        let thread = self
+            .registry
+            .find::<ThreadActor>(&browsing_context_actor.thread);
 
         let pause = self.registry.new_name::<PauseActor>();
         self.registry.register(PauseActor {
Diff in /home/runner/work/servo/servo/components/devtools/lib.rs:829:
             return;
         };
 
-        let browsing_context_actor = self.registry.find::<BrowsingContextActor>(browsing_context_name);
-        let thread = self.registry.find::<ThreadActor>(&browsing_context_actor.thread);
+        let browsing_context_actor = self
+            .registry
+            .find::<BrowsingContextActor>(browsing_context_name);
+        let thread = self
+            .registry
+            .find::<ThreadActor>(&browsing_context_actor.thread);
 
         let source = match thread
             .source_manager

 ➤  Checking formatting of python files...

 ➤  Checking formatting of toml files...


 ❌ test-tidy reported errors.
Run `./mach fmt` to fix the formatting

Did you add your changes and committed before doing the push? Because it seems that it didn't change anything between two versions. It has definitely happened to me before :)

./mach fmt
git commit -a -s "fix formatting"
git push

Did you add your changes and committed before doing the push? Because it seems that it didn't change anything between two versions. It has definitely happened to me before :)

./mach fmt
git commit -a -s "fix formatting"
git push

You're right, lol

Too many commands I forgot to git add before pushing

Apologies for taking this out of the merge queue, it had some conflicts in watcher.rs. Let's wait until #43472 is merged, since that also modifies the same parts of the lib.rs file.

Apologies for taking this out of the merge queue, it had some conflicts in watcher.rs. Let's wait until #43472 is merged, since that also modifies the same parts of the lib.rs file.

Okay, but #43472 now looks merged, can I rebase?

Yes, thanks!

Yes, thanks!

Can you review the commit, @eerii?