Skip to content

devtools: Renamed BrowsingContext in inspector & its actors#43642

Merged
mukilan merged 1 commit into
servo:mainfrom
sabbCodes:issue-43606-browsing-context-part-II
Mar 25, 2026
Merged

devtools: Renamed BrowsingContext in inspector & its actors#43642
mukilan merged 1 commit into
servo:mainfrom
sabbCodes:issue-43606-browsing-context-part-II

Conversation

@sabbCodes

@sabbCodes sabbCodes commented Mar 25, 2026 •
edited by mukilan
Loading

Copy link
Copy Markdown
Contributor

Renamed BrowsingContext in inspector, highlighter, page_style, style_rule & walker actors

Testing: No testing required.

Fixes: Part of #43606

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 25, 2026
@codecov-commenter

codecov-commenter commented Mar 25, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
887 1 886 0
View the top 1 failed test(s) by shortest run time 
servo::webview::test_contextual_context_menu_items
Stack Traces | 1.12s run time 
thread 'test_contextual_context_menu_items' (41940) panicked at .../servo/tests/webview.rs:713:21:
internal error: entered unreachable code: Exepcted to find context menu in controls
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: webview::test_contextual_context_menu_items::{{closure}}
   3: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sabbCodes

sabbCodes commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi @eerii @mukilan,

Is this error as a result of my commit?

@mukilan

mukilan commented Mar 25, 2026

Copy link
Copy Markdown
Member

No, that was an unrelated unit test being flaky.

mukilan
mukilan approved these changes Mar 25, 2026
View reviewed changes

@mukilan mukilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 25, 2026
@mukilan mukilan added this pull request to the merge queue Mar 25, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 25, 2026
Merged via the queue into servo:main with commit 02a2d45 Mar 25, 2026
56 of 58 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukilan mukilan mukilan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sabbCodes @codecov-commenter @mukilan @servo-highfive