Skip to content

devtools: Refactored ActorRegistry variables in lib.rs#43623

Merged
yezhizhen merged 2 commits into
servo:mainfrom
sabbCodes:issue-43605-batch-III
Mar 25, 2026
Merged

devtools: Refactored ActorRegistry variables in lib.rs#43623
yezhizhen merged 2 commits into
servo:mainfrom
sabbCodes:issue-43605-batch-III

Conversation

@sabbCodes

@sabbCodes sabbCodes commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Refactored the lib.rs file to replace ``actors&self.actors``` variables with ```registry``` and ```self.registry```

No testing required, compiles successfully.

Part o the #43605

Signed-off-by: Sabb <sarafaabbas@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 24, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 24, 2026
@Taym95 Taym95 enabled auto-merge March 24, 2026 17:58
@sabbCodes

Copy link
Copy Markdown
Contributor Author

Hi @Taym95 looks like one check is failing, kindly check it out

@eerii

eerii commented Mar 24, 2026

Copy link
Copy Markdown
Member

You will need to run ./mach fmt to format the changes. Running ./mach test-tidy after each commit is good since it can detect this problems before uploading :)

https://book.servo.org/contributing/making-a-pull-request.html#pull-request-checklist

@sabbCodes

Copy link
Copy Markdown
Contributor Author

Yeah, my mind immediately tells me that, it actually skipped my mind as I've not been doing that for previous pushes...

Will pay more attention to that henceforth.

Can you fix it or do I need to do something about it?

@eerii

eerii commented Mar 24, 2026

Copy link
Copy Markdown
Member

No worries, it happens! :)

To fix it you need to go to this branch on your local checkout, run ./mach fmt and create a new commit with the result. Then you just push it to the branch and the PR will be updated automatically. It is fine to have multiple commits as they will all be squashed when the PR is merged.

Signed-off-by: Sabb <sarafaabbas@gmail.com>
auto-merge was automatically disabled March 24, 2026 19:27

Head branch was pushed to by a user without write access

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 24, 2026
@eerii eerii enabled auto-merge March 24, 2026 19:40
@eerii eerii added this pull request to the merge queue Mar 24, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 24, 2026
@yezhizhen yezhizhen removed this pull request from the merge queue due to a manual request Mar 25, 2026
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 25, 2026
@sabbCodes

Copy link
Copy Markdown
Contributor Author

Hi @yezhizhen checking to see you don't forget to add this back

@yezhizhen yezhizhen added this pull request to the merge queue Mar 25, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 25, 2026
@yezhizhen

Copy link
Copy Markdown
Member

I did forget. Tio many things going on.

Merged via the queue into servo:main with commit 4820941 Mar 25, 2026
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants