script: React correctly to `selected` attributes changes in for `<option>` by SharanRP · Pull Request #43582 · servo/servo

SharanRP · 2026-03-23T20:18:16Z

Fixes: #43522

servo-wpt-sync · 2026-03-23T20:22:13Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58694) with upstreamable changes.

servo-wpt-sync · 2026-03-23T20:26:05Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58694).

github-actions · 2026-03-23T21:12:17Z

🔨 Triggering try run (#23460377363) for Linux (WPT)

github-actions · 2026-03-23T21:41:40Z

Test results for linux-wpt from try job (#23460377363):

Flaky unexpected result (40)

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
CRASH [expected ERROR] /_webgl/conformance2/misc/uninitialized-test-2.html (#41656)
TIMEOUT [expected OK] /content-security-policy/inheritance/document-write-iframe.html (#41195)
- TIMEOUT [expected PASS] subtest: document.open() keeps inherited CSPs on transient about:blank.
```
Test timed out
```
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
FAIL [expected PASS] /css/css-backgrounds/border-image-repeat-space-9.html
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/generic-family-keywords-002.html (#40929)
- FAIL [expected PASS] subtest: font-family: -webkit-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-sans-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-cursive treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-fantasy treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-monospace treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-system-ui treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-math treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- PASS [expected FAIL] subtest: font-family: -webkit-generic(fangsong) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(kai) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(khmer-mul) treated as <font-family>, not <generic-name>
- And 12 more unexpected results...
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
CRASH [expected OK] /html/anonymous-iframe/embedding.tentative.https.window.html?2-2
CRASH [expected OK] /html/browsers/browsing-the-web/history-traversal/api-availability.html

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- PASS [expected TIMEOUT] subtest: HTMLMediaElement.srcObject blob
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
CRASH [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
CRASH [expected OK] /html/webappapis/system-state-and-capabilities/the-navigator-object/secure_context.html
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
FAIL [expected PASS] /png/apng/fcTL-dispose-previous.html (#41561)
TIMEOUT [expected OK] /preload/modulepreload-sri-importmap.html (#43354)
- TIMEOUT [expected PASS] subtest: Script should not be loaded if modulepreload's integrity is invalid
```
Test timed out
```
TIMEOUT [expected OK] /preload/modulepreload-sri.html (#43354)
- TIMEOUT [expected PASS] subtest: Script should not be loaded if modulepreload's integrity is invalid
```
Test timed out
```
ERROR [expected OK] /resource-timing/cors-preflight.any.html (#28694)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- FAIL [expected PASS] subtest: Click event should be fired when touchend opens synchronous XHR
```
assert_equals: expected "touchend@div, mousedown@div, mouseup@div, click@div" but got "touchend@div"
```
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
OK /wasm/webapi/abort.any.html (#39966)
- FAIL [expected PASS] subtest: instantiateStreaming() asynchronously racing with abort should succeed or reject with AbortError
```
assert_equals: expected "AbortError" but got "CompileError"
```

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)

FAIL [expected PASS] subtest: buffer-stitching-2

assert_approx_equals: Stitched sine‑wave buffers at sample rate 43800 sample[25554] |1.6572019132257562e-24 - -0.24537639319896698| = 0.24537639319896698 &gt; 0.0038986 expected -0.24537639319896698 +/- 0.0038986 but got 1.6572019132257562e-24

CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html
OK /webdriver/tests/classic/accept_alert/accept.py (#43194)
- FAIL [expected PASS] subtest: test_accept_in_popup_window
```
AssertionError: no such alert (404): No user prompt is currently active.
```
OK /webdriver/tests/classic/execute_async_script/objects.py
- FAIL [expected PASS] subtest: test_object
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_script/arguments.py
- FAIL [expected PASS] subtest: test_null
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_script/cyclic.py
- FAIL [expected PASS] subtest: test_collection_self_reference
```
AssertionError
```
OK /webdriver/tests/classic/execute_script/window.py
- FAIL [expected PASS] subtest: test_web_reference[frame]
```
AssertionError: assert False
```
OK /webdriver/tests/classic/get_element_rect/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (15)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
```
assert_equals: quoted cursive matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
```
assert_equals: quoted monospace matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
```
assert_equals: quoted system-ui matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/semantics/embedded-content/media-elements/audio_loop_seek_to_eos.html (#41226)
- PASS [expected FAIL] subtest: seeking to the end of looping audio
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.

github-actions · 2026-03-23T21:41:54Z

✨ Try run (#23460377363) succeeded.

lukewarlow · 2026-03-24T14:41:59Z

I would be curious to see if the same bug occurs when using the .selected IDL property (which doesn't reflect to the selected attribute). Might be that this needs handling inside of selectedness changing rather than just the attribute.

servo-wpt-sync · 2026-03-24T15:24:49Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58694).

SharanRP · 2026-03-24T15:24:56Z

I also checked the .selected path ,the sync logic is already working there. I added a few simple tests for both single and multiple select using .selected, plus one to confirm it doesn’t reflect :)

lukewarlow · 2026-03-26T14:46:33Z

I've just tested this with my select multiple PR and it fixes the two error cases I came across.

servo-wpt-sync · 2026-03-27T12:18:44Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#58694) title and body.

servo-wpt-sync · 2026-03-27T12:19:54Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#58694) title and body.

Signed-off-by: SharanRP <z8903830@gmail.com>

servo-wpt-sync · 2026-03-27T12:27:31Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58694).

SharanRP requested a review from gterzian as a code owner March 23, 2026 20:18

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 23, 2026

SharanRP force-pushed the sel branch from cbe9c28 to f73733e Compare March 23, 2026 20:19

servo-wpt-sync mentioned this pull request Mar 23, 2026

script: React correctly to selected attributes changes in for <option> web-platform-tests/wpt#58694

Merged

simonwuelker added the T-linux-wpt Do a try run of the WPT label Mar 23, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Mar 23, 2026

SharanRP force-pushed the sel branch from f73733e to fa44a42 Compare March 24, 2026 15:18

lukewarlow approved these changes Mar 26, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 26, 2026

mrobinson changed the title ~~Fix select on option selected attr changefix sel~~ script: React correctly to selected attributes changes in for <option> Mar 27, 2026

mrobinson approved these changes Mar 27, 2026

View reviewed changes

mrobinson enabled auto-merge March 27, 2026 12:23

fix sel

291b029

Signed-off-by: SharanRP <z8903830@gmail.com>

mrobinson force-pushed the sel branch from fa44a42 to 291b029 Compare March 27, 2026 12:23

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 27, 2026

mrobinson added this pull request to the merge queue Mar 27, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 27, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 27, 2026

mrobinson added this pull request to the merge queue Mar 27, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 27, 2026

Merged via the queue into servo:main with commit 6dd4276 Mar 27, 2026
39 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 27, 2026

Uh oh!

Conversation

SharanRP commented Mar 23, 2026 • edited by mrobinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Mar 23, 2026

Uh oh!

servo-wpt-sync commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

lukewarlow commented Mar 24, 2026

Uh oh!

servo-wpt-sync commented Mar 24, 2026

Uh oh!

SharanRP commented Mar 24, 2026

Uh oh!

lukewarlow commented Mar 26, 2026

Uh oh!

servo-wpt-sync commented Mar 27, 2026

Uh oh!

servo-wpt-sync commented Mar 27, 2026

Uh oh!

servo-wpt-sync commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SharanRP commented Mar 23, 2026 •

edited by mrobinson

Loading