Skip to content

webgl: Remove manual Drop implementation for WebGLQuery#43544

Merged
jdm merged 1 commit into
servo:mainfrom
willypuzzle:26488-Drop-impls-for-DOM-types-should-be-forbidden-WebGLQuery
Mar 22, 2026
Merged

webgl: Remove manual Drop implementation for WebGLQuery#43544
jdm merged 1 commit into
servo:mainfrom
willypuzzle:26488-Drop-impls-for-DOM-types-should-be-forbidden-WebGLQuery

Conversation

@willypuzzle

@willypuzzle willypuzzle commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Moves the cleanup logic to a separate helper struct to comply with the prohibition of manual Drop implementations for DOM types.

Testing: WebGL tests just cover its parts
Fixes: Partially #26488

@willypuzzle willypuzzle requested a review from gterzian as a code owner March 22, 2026 20:13
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 22, 2026
@willypuzzle willypuzzle force-pushed the 26488-Drop-impls-for-DOM-types-should-be-forbidden-WebGLQuery branch from e533d68 to d9fa2c1 Compare March 22, 2026 20:14
jdm
jdm approved these changes Mar 22, 2026
View reviewed changes

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 22, 2026
@jdm jdm added the S-fails-tidy `./mach test-tidy` reported errors. label Mar 22, 2026
@willypuzzle
webgl: Remove manual Drop implementation for WebGLQuery (servo#26488)
f6eefbe 
Moves the cleanup logic to a separate helper struct to comply with the
prohibition of manual `Drop` implementations for DOM types.

Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>
@willypuzzle willypuzzle force-pushed the 26488-Drop-impls-for-DOM-types-should-be-forbidden-WebGLQuery branch from d9fa2c1 to f6eefbe Compare March 22, 2026 20:22
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 22, 2026
@jdm jdm enabled auto-merge March 22, 2026 20:24
@jdm jdm added this pull request to the merge queue Mar 22, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 22, 2026
Merged via the queue into servo:main with commit 1e514bc Mar 22, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 22, 2026
@willypuzzle willypuzzle deleted the 26488-Drop-impls-for-DOM-types-should-be-forbidden-WebGLQuery branch March 22, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed. S-fails-tidy `./mach test-tidy` reported errors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willypuzzle @jdm @servo-highfive