Metadata: Add missing repository information#43451
Merged
Merged
Conversation
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
TimvdLippe
approved these changes
Mar 19, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Add further missing repository keys / descriptions, which I missed in #43451 due to a suboptimal grep (assuming that rust-version.workspace is always the last item). Additionally fix crate self-references, which caused cargo-publish to fail, due to it trying to fetch the crate from crates.io. When specifying the current crate in `[dev-dependencies]` to enable a test feature or similar, apparently one should not use `workspace = true` and instead use `path`. This requires extending the previously added `tidy` check, to allow `path` dependencies in this specific case outside of the workspace Cargo.toml. Testing: Covered by existing tests --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
This fixes a warning of `cargo publish`: ``` warning: manifest has no description, documentation, homepage or repository ``` Testing: Compiling. Manual testing of `cargo publish --dry-run` (with some additional patches, and until the next error, shows this warning has been fixed) Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
Add further missing repository keys / descriptions, which I missed in servo#43451 due to a suboptimal grep (assuming that rust-version.workspace is always the last item). Additionally fix crate self-references, which caused cargo-publish to fail, due to it trying to fetch the crate from crates.io. When specifying the current crate in `[dev-dependencies]` to enable a test feature or similar, apparently one should not use `workspace = true` and instead use `path`. This requires extending the previously added `tidy` check, to allow `path` dependencies in this specific case outside of the workspace Cargo.toml. Testing: Covered by existing tests --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a warning of
cargo publish:Testing: Compiling. Manual testing of
cargo publish --dry-run(with some additional patches, and until the next error, shows this warning has been fixed)