script: Pass &mut JSContext to ReadableStream::cancel#43432
Merged
Conversation
Signed-off-by: Uiniel <174327181+uiniel@users.noreply.github.com>
TimvdLippe
approved these changes
Mar 18, 2026
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
Pass `&mut JSContext` to `ReadableStream::cancel`, in preparation of porting the remaining `BlobMethods`. Testing: Just a refactor, ./mach test-unit still passes. Fixes: Part of servo#42638 Signed-off-by: Uiniel <174327181+uiniel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
&mut JSContexttoReadableStream::cancel, in preparation of porting the remainingBlobMethods.Testing: Just a refactor, ./mach test-unit still passes.
Fixes: Part of #42638