Skip to content

script: Port Notification to mozjs JSContext#43302

Merged
TimvdLippe merged 3 commits into
servo:mainfrom
yezhizhen:mission2
Mar 16, 2026
Merged

script: Port Notification to mozjs JSContext#43302
TimvdLippe merged 3 commits into
servo:mainfrom
yezhizhen:mission2

Conversation

@yezhizhen

@yezhizhen yezhizhen commented Mar 16, 2026

Copy link
Copy Markdown
Member

Mission No.2

Divided into three parts

  • Import js::context::JSContext; and use it. This is fine as we already renamed the traditional one.
  • Major mission of porting
  • Add space between functions

Testing: It compiles

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
@yezhizhen yezhizhen requested a review from gterzian as a code owner March 16, 2026 06:07
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 16, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 16, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 16, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 16, 2026
Merged via the queue into servo:main with commit fc76797 Mar 16, 2026
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 16, 2026
@yezhizhen yezhizhen deleted the mission2 branch March 16, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants