script: Pass &mut JSContext to children_changed and adopting_steps#43219
Merged
Conversation
TimvdLippe
approved these changes
Mar 12, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
It's a lot, but luckily it's all mechanical. I would prefer smaller PRs, but I also know that for these that's near impossible. Just couple of nits for issue bookkeeping, so we don't forget to clean these up
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…ps` (servo#43219) Switch `VirtualMethods::children_changed` and `VirtualMethods::adopting_steps` to `&mut JSContext`. Testing: No behaviour change, a successful build is enough. Part of servo#40600 --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com> (cherry picked from commit 048612f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch
VirtualMethods::children_changedandVirtualMethods::adopting_stepsto&mut JSContext.Testing: No behaviour change, a successful build is enough.
Part of #40600