script: Log uncaught JS exceptions to the console#43191
Merged
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
9d00306 to
a3e612e
Compare
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
a3e612e to
abcb7ae
Compare
|
🔨 Triggering try run (#22971848928) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22971848928): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (1)
|
|
|
TimvdLippe
approved these changes
Mar 11, 2026
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
The script execution code has changed a bit in the last months so some things that used to work don't anymore. This change ensures that when an exception is thrown it is logged to the console. Testing: Regressions are covered by wpt, but we can't run tests for the presence of `log::error!` calls --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> (cherry picked from commit 333e195)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script execution code has changed a bit in the last months so some things that used to work don't anymore.
This change ensures that when an exception is thrown it is logged to the console.
Testing: Regressions are covered by wpt, but we can't run tests for the presence of
log::error!calls