Skip to content

devtools: create helper functions to reduce duplication in tests#43140

Merged
atbrakhi merged 1 commit into
servo:mainfrom
atbrakhi:create_handler_in_devtoolstests
Mar 10, 2026
Merged

devtools: create helper functions to reduce duplication in tests#43140
atbrakhi merged 1 commit into
servo:mainfrom
atbrakhi:create_handler_in_devtoolstests

Conversation

@atbrakhi

Copy link
Copy Markdown
Member

Create helper functions to reduce boilerplate in some tests

Testing: All tests are passing
Fixes: See comment #43135 (review)

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 10, 2026
@atbrakhi atbrakhi requested a review from eerii March 10, 2026 14:44
@atbrakhi atbrakhi force-pushed the create_handler_in_devtoolstests branch from 410a174 to 499a616 Compare March 10, 2026 14:55
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi force-pushed the create_handler_in_devtoolstests branch from 499a616 to 3219b97 Compare March 10, 2026 15:11

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 10, 2026
@atbrakhi atbrakhi added this pull request to the merge queue Mar 10, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 10, 2026
Merged via the queue into servo:main with commit ed3e63d Mar 10, 2026
30 checks passed
@atbrakhi atbrakhi deleted the create_handler_in_devtoolstests branch March 10, 2026 16:42
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants