script: Pass &mut JSContext to DOM apis that call Element::create#43108
Merged
Conversation
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
&mut JSContext to DOM apis that call Element::create&mut JSContext to DOM apis that call Element::create
…lection` Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
TimvdLippe
approved these changes
Mar 9, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
…`Node::clone` (#43130) Continuation of #43108, two new `temp_cx()` calls were required: - inside `maybe_clone_an_option_into_selectedcontent` since it's part of a markup5ever trait - inside `serialize_and_cache_subtree` replacing a `CanGc::note()` call, propagating it inside reflow code will require even more effort. Testing: No behaviour change, a successful build is enough. Part of #40600 --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…servo#43108) Testing: No behaviour change, a successful build is enough. Part of servo#40600 --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com> (cherry picked from commit fa86bbe)
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
…`Node::clone` (servo#43130) Continuation of servo#43108, two new `temp_cx()` calls were required: - inside `maybe_clone_an_option_into_selectedcontent` since it's part of a markup5ever trait - inside `serialize_and_cache_subtree` replacing a `CanGc::note()` call, propagating it inside reflow code will require even more effort. Testing: No behaviour change, a successful build is enough. Part of servo#40600 --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com> (cherry picked from commit 4ef22ed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: No behaviour change, a successful build is enough.
Part of #40600