script: Add missing steps for parsing a legacy font size by shubhamg13 · Pull Request #43103 · servo/servo

shubhamg13 · 2026-03-09T07:01:16Z

In this change clamps legacy font size value of the <font> element to the range [1,7] according to steps 10, 11 of rules-for-parsing-a-legacy-font-size.

Testing: This causes a WPT test to start passing.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>

github-actions · 2026-03-09T07:06:07Z

🔨 Triggering try run (#22842240156) for Linux (WPT)

github-actions · 2026-03-09T07:46:20Z

Test results for linux-wpt from try job (#22842240156):

Flaky unexpected result (33)

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

ERROR [expected CRASH] /_webgl/conformance2/textures/misc/tex-3d-size-limit.html (#42881)

PASS [expected FAIL] subtest: WebGL test #1

FAIL [expected PASS] subtest: WebGL test #3

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #4

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #5

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #6

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #7

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #8

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #9

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #10

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #11

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

And 27 more unexpected results...

FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
CRASH [expected OK] /css/css-overflow/scroller-covered-by-empty-svg.html
FAIL [expected PASS] /css/css-ui/appearance-button-001.html
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
CRASH [expected OK] /html/browsers/browsing-the-web/history-traversal/event-order/after-load-pushState.html
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

CRASH [expected OK] /html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling.html
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
CRASH [expected OK] /html/canvas/element/canvas-host/2d.canvas.host.initial.reset.path.html
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- PASS [expected TIMEOUT] subtest: Feature-Policy header: autoplay "none" has no effect on the top level document.
- FAIL [expected TIMEOUT] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
assert_false: autoplay expected false got true
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin video should get upgraded even if CORS is set
```
assert_equals: Length. Other host expected 1 but got Infinity
```
FAIL [expected PASS] /png/apng/fcTL-dispose-previous-final.html (#41837)
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
OK /wasm/webapi/abort.any.worker.html (#40013)
- FAIL [expected PASS] subtest: compileStreaming() asynchronously racing with abort should succeed or reject with AbortError
```
assert_equals: expected "AbortError" but got "CompileError"
```
OK /webdriver/tests/classic/delete_cookie/delete.py
- FAIL [expected PASS] subtest: test_null_response_value
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/delete_cookie/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/find_elements/find.py
- ERROR [expected PASS] subtest: test_no_top_browsing_context
```
setup error: webdriver.error.NoSuchElementException: no such element (404)
```
OK /webdriver/tests/classic/get_title/get.py
- FAIL [expected PASS] subtest: test_payload
```
AssertionError: no such window (404)
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

Stable unexpected results that are known to be intermittent (15)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted sans-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-dest - Not sent to non-trustworthy same-site destination
```
Test timed out
```
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```
OK [expected TIMEOUT] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
- FAIL [expected TIMEOUT] subtest: indexeddb
```
assert_equals: expected (undefined) undefined but got (string) "5e6814c8-b1cb-4c58-b15e-d597361cfa01"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload domInteractive > Original domInteractive
```
assert_true: Reload domInteractive &gt; Original domInteractive expected true got false
```
- FAIL [expected PASS] subtest: Reload fetchStart > Original fetchStart
```
assert_true: Reload fetchStart &gt; Original fetchStart expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

github-actions · 2026-03-09T07:49:03Z

✨ Try run (#22842240156) succeeded.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>

In this change clamps legacy font size value of the `<font>` element to the range [1,7] according to steps 10, 11 of [rules-for-parsing-a-legacy-font-size](https://html.spec.whatwg.org/multipage/rendering.html#rules-for-parsing-a-legacy-font-size). Testing: This causes a WPT test to start passing. --------- Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org> (cherry picked from commit c32d9f5)

shubhamg13 added 2 commits March 9, 2026 14:55

Complete missing step for rules-for-parsing-a-legacy-font-size

b712fab

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>

Update WPT tests expectations

e1dd7f5

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>

shubhamg13 requested a review from gterzian as a code owner March 9, 2026 07:01

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2026

shubhamg13 changed the title ~~dom: Complete steps for parsing a legacy font size.~~ dom: Add missing steps for parsing a legacy font size. Mar 9, 2026

shubhamg13 requested a review from xiaochengh March 9, 2026 07:02

shubhamg13 added the T-linux-wpt Do a try run of the WPT label Mar 9, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Mar 9, 2026

mrobinson requested changes Mar 9, 2026

View reviewed changes

Comment thread components/script/dom/html/htmlfontelement.rs Outdated

servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 9, 2026

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 9, 2026

shubhamg13 requested a review from mrobinson March 9, 2026 09:28

Add Spec Steps

0173397

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>

shubhamg13 force-pushed the rules-for-parsing-a-legacy-font-size-fix branch from fae89fb to 0173397 Compare March 9, 2026 09:29

mrobinson changed the title ~~dom: Add missing steps for parsing a legacy font size.~~ script: Add missing steps for parsing a legacy font size Mar 9, 2026

mrobinson approved these changes Mar 9, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2026

mrobinson enabled auto-merge March 9, 2026 09:38

mrobinson added this pull request to the merge queue Mar 9, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026

Merged via the queue into servo:main with commit c32d9f5 Mar 9, 2026
32 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026

shubhamg13 deleted the rules-for-parsing-a-legacy-font-size-fix branch March 9, 2026 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Add missing steps for parsing a legacy font size#43103

script: Add missing steps for parsing a legacy font size#43103
mrobinson merged 3 commits into
servo:mainfrom
shubhamg13:rules-for-parsing-a-legacy-font-size-fix

shubhamg13 commented Mar 9, 2026 •

edited by mrobinson

Loading

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shubhamg13 commented Mar 9, 2026 • edited by mrobinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shubhamg13 commented Mar 9, 2026 •

edited by mrobinson

Loading