script: Add error messages in HTMLDialogElement#43101
Merged
Merged
Conversation
Signed-off-by: xzaisk <zkhalid99v@gmail.com>
Signed-off-by: xzaisk <zkhalid99v@gmail.com>
1030876 to
62b95c0
Compare
yezhizhen
approved these changes
Mar 9, 2026
yezhizhen
reviewed
Mar 9, 2026
InvalidState expects an Option<String> (Some) Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com> Signed-off-by: Zain <39714482+xZaisk@users.noreply.github.com>
auto-merge was automatically disabled
March 9, 2026 06:34
Head branch was pushed to by a user without write access
yezhizhen
approved these changes
Mar 9, 2026
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
Adds specific InvalidStateError messages in HTMLDialogElement for `show()` and `showModal()` error paths. A fix part of servo#40756. --------- Signed-off-by: xzaisk <zkhalid99v@gmail.com> Signed-off-by: Zain <39714482+xZaisk@users.noreply.github.com> Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com> (cherry picked from commit 2cc8ae3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds specific InvalidStateError messages in HTMLDialogElement for
show()andshowModal()error paths.A fix part of #40756.