css: Enable jump-start, jump-both, jump-end, jump-none step-position#43061
Conversation
|
🔨 Triggering try run (#22767317286) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22767317286): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (8)
|
|
|
|
FYI @lukewarlow about |
xiaochengh
left a comment
There was a problem hiding this comment.
Just let me try to understand the situation: these keywords are already implemented in Servo, and the only thing we need to do is to enable parsing?
@xiaochengh Indeed. They were tested with examples in #43060. before-fix.mp4post-fix.mp4 |
@xiaochengh The animation progress calculation is done In Stylo instead of Servo: relevant stylo code All servo did is retrieving the computed servo/components/script/layout_dom/element.rs Lines 280 to 282 in 42d228d |
215f4c2 to
314b365
Compare
jump-start, jump-both, jump-end, jump-none step-positionjump-start, jump-both, jump-end, jump-none step-position
|
@Loirooriol Do you think we should add 4 ref tests? My idea is to use comibination of negative delay (necessary to distinguish between jump-none and jump-end) to test certain frame. Right now these tests are written with Web Animations API, which we don't support... None of the passing tests involve actual animation rendering. servo/tests/wpt/tests/css/css-easing/step-timing-functions-output.html Lines 106 to 118 in 9394cdf |
|
Sounds good. Indeed using paused animations with a negative delay, you can check the outcome at the desired % |
Speaking of which, we have another bug: #43080, that blocks us from testing multiple % in one test.. Guess we just test one single critical then.. |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58352) with upstreamable changes. |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58352). |
This enables `jump-start`, `jump-end`, `jump-none`, `jump-both`. The feature is left here 7 years ago. As tested with examples, all `step-easing-function`s work as expected. Servo PR: servo/servo#43061 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com> Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58352). |
|
Merging after upstream task-cluster finishes. EDIT: DCO never started.. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58352). |
…osition (servo#43061) (linux-wpt) {"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
Bumps stylo to servo/stylo#323
As tested with examples, all step-position keywords now work: https://drafts.csswg.org/css-easing-2/#typedef-step-position
Testing: New passing WPT. Several in
moveBeforegoes from TIMEOUT toFAIL, as the API is not enabled in Servo. Added 4 new tests to test the proper rendering.Fixes: #43060