indexeddb: align getAll/getAllKeys and convert_value_to_key with IndexedDB spec#43041
Merged
Taym95 merged 1 commit intoMar 18, 2026
Merged
Conversation
|
🔨 Triggering try run (#22728440220) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22728440220): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (17)
|
|
✨ Try run (#22728440220) succeeded. |
|
🔨 Triggering try run (#23051614714) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23051614714): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (14)
|
|
✨ Try run (#23051614714) succeeded. |
janvarga
approved these changes
Mar 13, 2026
janvarga
left a comment
Member
There was a problem hiding this comment.
Looks good to me, nice to have all those "step" comments in the code.
| })? | ||
| .collect::<Result<Vec<_>, _>>()?; | ||
|
|
||
| let mut models_with_keys = models |
Member
There was a problem hiding this comment.
Do I understand this correctly, that all db rows are loaded into memory and only then filtered?
I believe the filtering could/should be done at db level in future, can you add a TODO for that?
gterzian
approved these changes
Mar 17, 2026
| for seen_input in &seen { | ||
| let mut same = false; | ||
| if unsafe { !SameValue(cx.raw_cx(), *seen_input, input, &mut same) } { | ||
| return Err(Error::JSFailed); |
Member
There was a problem hiding this comment.
Should you not just return ConversionResult::Invalid? Depends on the tests really.
Member
Author
There was a problem hiding this comment.
The Err(Error::JSFailed) branch is only for SameValue itself failing not for “seen contains input” when same == true
| } | ||
|
|
||
| // If input is a Date (has a [[DateValue]] internal slot): | ||
| if let ESClass::Date = built_in_class { |
| if !js::rust::wrappers2::DateGetMsecSinceEpoch(cx, object.handle(), &mut f) { | ||
| // 3.1. Let ms be the value of input's [[DateValue]] internal slot. | ||
| let mut ms = f64::NAN; | ||
| if !js::rust::wrappers2::DateGetMsecSinceEpoch(cx, object.handle(), &mut ms) { |
| let is_detached = if IsArrayBufferObject(*object) { | ||
| IsDetachedArrayBufferObject(*object) | ||
| } else { | ||
| let mut is_shared = false; |
Member
There was a problem hiding this comment.
Note that we don't support it, so its false by default.
| } | ||
|
|
||
| // If input is an Array exotic object: | ||
| if let ESClass::Array = built_in_class { |
…xedDB spec and update WPT metadata Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
ee1688a to
d556366
Compare
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
…xedDB spec (servo#43041) indexeddb: align getAll/getAllKeys and convert_value_to_key with IndexedDB spec and update WPT expectation Testing: more IndexedDB test are passing. part of servo#40983 Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexeddb: align getAll/getAllKeys and convert_value_to_key with IndexedDB spec and update WPT expectation
Testing: more IndexedDB test are passing.
part of #40983