net: Ignore subresource integrity with invalid base64 value#42931
Merged
Conversation
Contributor
Author
|
It's possible to defer this to the csp crate, but more changes will probably be needed. |
TimvdLippe
approved these changes
Mar 1, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Needs rebase for Cargo.lock
Taym95
approved these changes
Mar 1, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
) Found this while analysing module preload test failures. In particular a subtest of `modulepreload.html` was recently [updated](web-platform-tests/wpt#57243) to catch this. We need to ensure that SRI hash follows the base64 grammar specified by CSP. Testing: Updated test expectations of a test --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
) Found this while analysing module preload test failures. In particular a subtest of `modulepreload.html` was recently [updated](web-platform-tests/wpt#57243) to catch this. We need to ensure that SRI hash follows the base64 grammar specified by CSP. Testing: Updated test expectations of a test --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while analysing module preload test failures. In particular a subtest of
modulepreload.htmlwas recently updated to catch this.We need to ensure that SRI hash follows the base64 grammar specified by CSP.
Testing: Updated test expectations of a test