-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
CookieSource type should be exported in public libservo API #44102
Copy link
Copy link
Closed
Labels
A-embeddingC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.
Metadata
Metadata
Assignees
Labels
A-embeddingC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.
Type
Fields
Give feedbackNo fields configured for issues without a type.
servo/components/servo/site_data_manager.rs
Line 9 in 80e8441
https://github.com/servo/servo/blob/80e84412318c626d80b9fd4ac956d77f0ba81d0d/components/servo/site_data_manager.rs#L210C12-L210C27
We should add a
pub useto https://github.com/servo/servo/blob/main/components/servo/servo.rs that re-exports the CookieSource type in the public libservo API, then usecrate::CookieSourcein site_data_manager.rs. This will make the docs.rs content more helpful, and ensure that embedders only need to depend on libservo, not any other sub-crates.