Noticed this while working on import maps, all Console::internal_warn callers instantiate a DOMString just for it, which will then clone the value. We probably should just use a String and remove the call to clone.
|
pub(crate) fn internal_warn(global: &GlobalScope, message: DOMString) { |
|
Console::send_string_message(global, ConsoleLogLevel::Warn, String::from(message.clone())); |
|
} |
Task:
Change the signature of the Console::internal_warn so that the second argument is a String type and remove the call to clone in the method body. Compilation should show errors at all existing callers to internal_warn that need to be modified. At those call sites, we can directly pass the result of format! to internal_warn instead of passing it to DOMString::from.
Noticed this while working on import maps, all
Console::internal_warncallers instantiate aDOMStringjust for it, which will then clone the value. We probably should just use a String and remove the call to clone.servo/components/script/dom/console.rs
Lines 122 to 124 in cea658e
Task:
Change the signature of the
Console::internal_warnso that the second argument is aStringtype and remove the call toclonein the method body. Compilation should show errors at all existing callers tointernal_warnthat need to be modified. At those call sites, we can directly pass the result offormat!tointernal_warninstead of passing it toDOMString::from.