Skip to content

Serialize rcdom iteratively#372

Merged
bors-servo merged 4 commits into
masterfrom
iterate
Apr 27, 2019
Merged

Serialize rcdom iteratively#372
bors-servo merged 4 commits into
masterfrom
iterate

Conversation

@jdm

@jdm jdm commented Apr 26, 2019

Copy link
Copy Markdown
Member

Fixes #371.

@Manishearth

Copy link
Copy Markdown
Member

@bors-servo r+

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 19eba5d has been approved by Manishearth

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 19eba5d with merge 639b65b...

bors-servo pushed a commit that referenced this pull request Apr 26, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@jdm

jdm commented Apr 26, 2019

Copy link
Copy Markdown
Member Author

@bors-servo r=Manishearth

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit ebfffde has been approved by Manishearth

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit ebfffde with merge 16c0243...

bors-servo pushed a commit that referenced this pull request Apr 26, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@CYBAI

CYBAI commented Apr 27, 2019

Copy link
Copy Markdown
Member

Maybe markup5ever's version in both html5ever and xml5ever needs to be updated as well 👀?

+cargo bench --all
    Updating crates.io index
error: failed to select a version for the requirement `markup5ever = "^0.7"`
  candidate versions found which didn't match: 0.8.0
  location searched: /home/travis/build/servo/html5ever/markup5ever
required by package `html5ever v0.22.7 (/home/travis/build/servo/html5ever/html5ever)`
The command "scripts/travis-build.sh" exited with 101.

@jdm

jdm commented Apr 27, 2019

Copy link
Copy Markdown
Member Author

@bors-servo r=manishearth

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 014b3ce has been approved by manishearth

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 014b3ce with merge 121523b...

bors-servo pushed a commit that referenced this pull request Apr 27, 2019
Serialize rcdom iteratively

Fixes #371.
@bors-servo

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis
Approved by: manishearth
Pushing 121523b to master...

@bors-servo bors-servo merged commit 014b3ce into master Apr 27, 2019
bors-servo pushed a commit that referenced this pull request May 3, 2019
Expose public Node constructor.

Since #372 there is a private field in Node that prevents constructing them manually. If we want to support that, we need to expose the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite RcDom's serialize implementation to be iterative

4 participants