Add names used by the HTMLTrackElement#361
Merged
Merged
Conversation
jdm
approved these changes
Dec 12, 2018
jdm
left a comment
Member
There was a problem hiding this comment.
Please update the markup5ever crate version as well!
a04f32b to
d358a47
Compare
Contributor
Author
|
👍 bumped to |
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit d358a47 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Dec 12, 2018
Add names used by the HTMLTrackElement Add `kind` and `srclang` to the list of `local_names`. They are needed by the HTMLTrackElement.
Contributor
|
💥 Test timed out |
|
@bors-servo retry |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2018
Add names used by the HTMLTrackElement Add `kind` and `srclang` to the list of `local_names`. They are needed by the HTMLTrackElement.
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
kindandsrclangto the list oflocal_names. They are neededby the HTMLTrackElement.