Add Apikey in generic webhook - #1526
Merged
Merged
Conversation
J12934
previously requested changes
Jan 3, 2023
J12934
left a comment
Member
There was a problem hiding this comment.
Hi, thank you for the PR 🙌🚀
I think there a a couple of errors which would prevent this from working, I've noted them down in the review below.
Can you please also take a look at the DCO requirements listed here: https://github.com/secureCodeBox/secureCodeBox/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-and-licensing
I can't merge PRs without it.
Signed-off-by: Renato Burton <renatoburton96@gmail.com>
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de> Signed-off-by: Renato Burton <renatoburton96@gmail.com>
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de> Signed-off-by: Renato Burton <renatoburton96@gmail.com>
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de> Signed-off-by: Renato Burton <renatoburton96@gmail.com>
Signed-off-by: Renato Burton <renatoburton96@gmail.com>
Signed-off-by: Renato Burton <renatoburton96@gmail.com>
srburton
force-pushed
the
add-identification-apikey
branch
from
January 5, 2023 02:29
bef7de8 to
c7dfaf3
Compare
|
@rseedorff, could you tell me the release forecast for version 4.0.0? thanks!! |
Member
|
Hi @renatosazup, |
|
@rseedorff you can merge yes, it's ready 😄 |
rfelber
marked this pull request as ready for review
February 22, 2023 12:24
rfelber
approved these changes
Feb 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist