Click the scriptish tbb should not disable scriptish#85
Closed
Click the scriptish tbb should not disable scriptish#85
Conversation
Member
|
My take on this... |
Member
Author
|
Yah I never liked this but wanted to follow gm, let's change this. |
Member
|
Feel free to merge this PR then at any time ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UX of almost every other button I have tried is to open the associated menu when a toolbar button is clicked, but with Scriptish and GM the experience is very different..
There should be a disable/enable menu item, and click the button or badge should open the menu.
Right now the badge opens the menu and the button disables Scriptish..