Skip to content

Comments

Deprecate Request#setConnectionKeepAlive()#521

Closed
wldaunfr wants to merge 3 commits intoscribejava:masterfrom
validio:master
Closed

Deprecate Request#setConnectionKeepAlive()#521
wldaunfr wants to merge 3 commits intoscribejava:masterfrom
validio:master

Conversation

@wldaunfr
Copy link

@wldaunfr wldaunfr commented Nov 19, 2014

See #520 for details.

@wldaunfr
Remove Request#setConnectionKeepAlive()
d7c173c
@wldaunfr
Add deprecated Request#setConnectionKeepAlive()
a79166f 
Add deprecated null-implementation to not break existing clients.
fernandezpablo85
fernandezpablo85 reviewed Nov 21, 2014
View reviewed changes
src/main/java/org/scribe/model/Request.java Outdated
Copy link
Collaborator

@fernandezpablo85 fernandezpablo85 Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd focus in how you can achieve a similar effect (e.g. setting the system property) and not in what the method used to do.

@rockihack
Copy link

rockihack commented Nov 19, 2015

Please remove System.setProperty("http.keepAlive", ...); soon. It's a nasty thing to modify global jvm settings. OAuth10aServiceImpl.getRequestToken() also uses OAuthRequest and keepAlive defaults to false. There is currently no way to modify this behavior and it results in large ssl overhead if you send many requests.

scribejava/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aServiceImpl.java

Line 45 in 0419502

final OAuthRequest request = new OAuthRequest(api.getRequestTokenVerb(), api.getRequestTokenEndpoint(), this);

@kullfar
Copy link
Member

kullfar commented Feb 26, 2016

outdated. In case it's actual, rebase on the master pls

@kullfar kullfar closed this Feb 26, 2016
@rockihack
Copy link

rockihack commented Feb 28, 2016

The issue is not outdated.
As long as you use System.setProperty("http.keepAlive", ...); it remains the same.
I tested it with latest release 2.3.0.

@kullfar
Copy link
Member

kullfar commented Feb 29, 2016

yep. you are right. reopening the issue

@kullfar kullfar reopened this Feb 29, 2016
@kullfar
Copy link
Member

kullfar commented Jul 22, 2016 •
edited
Loading

eventually have merged ;-) Thx to all

@kullfar
Copy link
Member

kullfar commented Oct 11, 2016

fixed

@kullfar kullfar closed this Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wldaunfr @rockihack @kullfar @fernandezpablo85