Skip to content

fix(oxlint): enable typescript/no-unnecessary-condition as error - #3500

Draft
philibea wants to merge 1 commit into
mainfrom
chore/oxlint-no-unnecessary-condition
Draft

fix(oxlint): enable typescript/no-unnecessary-condition as error#3500
philibea wants to merge 1 commit into
mainfrom
chore/oxlint-no-unnecessary-condition

Conversation

@philibea

Copy link
Copy Markdown
Collaborator

Enable typescript/no-unnecessary-condition as an error by removing its warn downgrade and fixing all violations across the codebase.

Closes #3399

@philibea
philibea requested a review from remyleone as a code owner September 10, 2026 21:08
@philibea philibea added the ai PRs created by AI label Sep 10, 2026
@changeset-bot

changeset-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6292363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (525f16b) to head (6292363).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3500   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files          50       50           
  Lines        1044     1044           
  Branches      275      275           
=======================================
  Hits          930      930           
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage-agent

The overall line coverage in commit 6292363 in the chore/oxlint-no-unne... branch remains at 88%, unchanged from commit 459a2c3 in the main branch.

@remyleone
remyleone marked this pull request as draft September 11, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai PRs created by AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oxlint: enable typescript/no-unnecessary-condition as error

3 participants