Forward HTTP status code for sync requests#375
Merged
yunfeng-scale merged 5 commits intomainfrom Nov 15, 2023
Merged
Conversation
yixu34
approved these changes
Nov 14, 2023
Member
yixu34
left a comment
There was a problem hiding this comment.
Nice! Let's make an announcement before deploying this, because even though this is backwards compatible (schema-wise) and is more correct, it may surprise people if their alarms start going off.
Contributor
iiuc we'd either need to update forwarder images on everyone's existing deployments or have people update their deployments for the changes to be picked up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
We used to always forward with 200s ignoring downstream HTTP codes, now forwarding the code as well
Test Plan and Usage Guide
unit tests and tested with echo server to make sure 500 status was forwarded