perf: skip the boxed_local walk for functions without a Box parameter#17168
Merged
Conversation
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
While you're changing this can you just initialize the delegate with the candidate arguments directly rather than the current awkward initialization of the candidates via the |
73f684e to
bc274fe
Compare
Jarcho
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
boxed_locallint ran anExprUseVisitorborrow/move walk over every function, method and closure body, even though it can only ever flag a parameter whose type is a non-traitBox<T>. This checks the parameter types up front and skips the walk when none qualifies.Instruction counts for
clippy-driver(clippy only, notcargo check) with deps cached, undervalgrind --tool=callgrind, master vs this change:changelog: none