fix: \extract_function\ misses \&mut\ for \container[i].mut_method()\#22523
Merged
A4-Tacks merged 1 commit intoJun 6, 2026
Merged
Conversation
A4-Tacks
approved these changes
Jun 5, 2026
Member
|
Maybe you need to rebase |
…od()\` fixes rust-lang#20162 \`expr_require_exclusive_access\` had no \`IndexExpr\` case, so \`container[i].mut_method()\` fell through to \`Some(false)\`. \`WRITE\` is only set on direct assignments, so method calls through an index were not detected as requiring exclusive access, and the container was extracted as \`&container\` instead of \`&mut container\`.
auto-merge was automatically disabled
June 6, 2026 14:57
Head branch was pushed to by a user without write access
55f59db to
256fe3e
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`expr_require_exclusive_access` had no `IndexExpr` case so `container[i].mut_method()` fell through to `Some(false)`. `WRITE` is only set on direct assignments so method calls through an index were not detected as requiring exclusive access and the container was extracted as `&container` instead of `&mut container`.
fixes #20162