fix: rename schema subItems with sub_items#22444
Conversation
|
Hmm, I always write subitem, not sub-item, as if it's a single word. |
|
Or change the renaming config of serde?
However, considering that it has already been released, it may be necessary to consider breaking |
|
It is a breaking change (although the breakage is minimal). If we had come up with this initially, fine, but now, I don't think it's worth the breakage. |
|
I wouldn't be that worried about the breaking change, most users didn't even update yet. There are more people who win the lottery than those who might be affected by this. |
|
True, on the other hand I wouldn't be worried about this change either. If it was something clearly better, maybe. |
|
Can we merge now? |
|
I still think we should not merge this, but I agree that if we do we should do it now. |
|
Btw, this PR doesn't have any breaking, it's just to make the schema correct |
Fixup #22416