Skip to content

fix: rename schema subItems with sub_items#22444

Merged
ChayimFriedman2 merged 1 commit into
rust-lang:masterfrom
A4-Tacks:exclude-config-rename
Jun 8, 2026
Merged

fix: rename schema subItems with sub_items#22444
ChayimFriedman2 merged 1 commit into
rust-lang:masterfrom
A4-Tacks:exclude-config-rename

Conversation

@A4-Tacks

@A4-Tacks A4-Tacks commented May 25, 2026

Copy link
Copy Markdown
Member

Fixup #22416

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2026
@A4-Tacks A4-Tacks requested a review from ChayimFriedman2 May 25, 2026 08:07
@lnicola

lnicola commented May 25, 2026

Copy link
Copy Markdown
Member

Hmm, I always write subitem, not sub-item, as if it's a single word.

@A4-Tacks

Copy link
Copy Markdown
Member Author

Or change the renaming config of serde?

subItems, sub_items, subitems

However, considering that it has already been released, it may be necessary to consider breaking

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

It is a breaking change (although the breakage is minimal). If we had come up with this initially, fine, but now, I don't think it's worth the breakage.

@lnicola

lnicola commented May 25, 2026

Copy link
Copy Markdown
Member

I wouldn't be that worried about the breaking change, most users didn't even update yet. There are more people who win the lottery than those who might be affected by this.

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

True, on the other hand I wouldn't be worried about this change either. If it was something clearly better, maybe.

@A4-Tacks

A4-Tacks commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Can we merge now?
It's best to merge as soon as possible, otherwise users will be confused about the schema

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

I still think we should not merge this, but I agree that if we do we should do it now.

@A4-Tacks

A4-Tacks commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Btw, this PR doesn't have any breaking, it's just to make the schema correct

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Jun 8, 2026
Merged via the queue into rust-lang:master with commit 4fde9dd Jun 8, 2026
19 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2026
@A4-Tacks A4-Tacks deleted the exclude-config-rename branch June 8, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants