fix: Fix SyntaxContext::roots technically overlapping valid interneds#21566
Merged
Conversation
58642b8 to
387d026
Compare
This comment has been minimized.
This comment has been minimized.
387d026 to
5f59f28
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
55e4e02 to
4530db9
Compare
4530db9 to
97ad069
Compare
97ad069 to
38ff036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we can hit this in practice, but better safe than sorry.
The more interesting part of this PR is that we are now hiding all functions that inspect the root encoding from the non-salsa interface, this is to prevent the proc-macro server from accidentally relying on this as that would mean changing the encoding will break it.