-
Notifications
You must be signed in to change notification settings - Fork 91
WIP: support for draft-ietf-openpgp-persistent-symmetric-keys #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
04eca35 to
964646d
Compare
3eeb4cd to
c28dbb3
Compare
491a545 to
f2a0d4c
Compare
| } | ||
| } | ||
|
|
||
| pub struct UnlockablePersistentSymmetricKey<'a> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this concept is new, why do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea for that type was that it allows passing a Password into a regular encrypt and verify call like in d09cd49.
That seems like a reasonably nice way to hide away the need for a password from the rest of the code.
| impl<'a> VerifyingKey for UnlockablePersistentSymmetricKey<'a> { | ||
| fn verify( | ||
| &self, | ||
| _hash: HashAlgorithm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should at least check it in some form
This is an early implementation of draft-ietf-openpgp-persistent-symmetric-keys.
This PR branch is intended for interop testing, and should not be merged before the draft arrives in a sufficiently stable state in the OpenPGP WG!
TODO: