Code deploy#48
Merged
Merged
Conversation
cabarnes
requested changes
Mar 2, 2017
| - sudo apt-get install -qq graphviz-dev python-setuptools python3-dev python-virtualenv python-pip | ||
| - sudo apt-get install -qq firefox automake libtool libreadline6 libreadline6-dev libreadline-dev | ||
| - sudo apt-get install -qq libsqlite3-dev libxml2 libxml2-dev libssl-dev libbz2-dev wget curl llvm | ||
| - sudo apt-get update -qq |
Member
There was a problem hiding this comment.
The other .yml files still have this indentation. Why did you change these?
Collaborator
Author
There was a problem hiding this comment.
I used the travis client tool to generate the deploy stuff, and it must have changed those indents. I left if because I figured it knew best.
| @@ -0,0 +1,5 @@ | |||
| #!/bin/bash | |||
| pushd /home/ubuntu/rovercode-web > /dev/null | |||
| docker-compose stop | |||
Member
There was a problem hiding this comment.
If you run docker-compose down it will remove the container as well
Member
There was a problem hiding this comment.
You might want to also want to delete the image because each docker-compose build will create a new one.
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
| cd /home/ubuntu/rovercode-web | |||
Member
There was a problem hiding this comment.
You may want to use && to combine all of these. Each is dependent on the previous step succeeding.
Collaborator
Author
|
Ok, changes done! |
cabarnes
approved these changes
Mar 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes travis automatically deploy development commits to beta.rovercode.com and master commits to rovercode.com.