feat: SidecarProcess.onStderr for live adapter log forwarding#118
Closed
abcxff wants to merge 2 commits into
Closed
feat: SidecarProcess.onStderr for live adapter log forwarding#118abcxff wants to merge 2 commits into
abcxff wants to merge 2 commits into
Conversation
http2.connect() with no explicit port (e.g. "https://host") shipped port: "" to the sidecar, because WHATWG URL.port is the empty string for protocol-default ports and ?? only falls back on null/undefined. The sidecar then failed to deserialize "" into Option<u16>: ERR_AGENTOS_NODE_SYNC_RPC: net.http2_session_connect payload must be valid JSON: invalid type: string "", expected u16 Coerce the raw port to a number, mapping ""/undefined/null to undefined so the field is omitted. The sidecar already defaults an absent port via url.port()/80, so no Rust change is required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The sidecar re-emits the in-VM agent adapter's stderr on its own stderr (tagged "ACP adapter stderr"), but it was only buffered and surfaced on process exit — embedders had no way to stream it live. Add SidecarProcess.onStderr(), delegating to the protocol client's already-public child stderr, so callers can route adapter logs to their own logger. Coexists with the internal exit-diagnostics buffering. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-118
June 23, 2026 23:21
Destroyed
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-118
June 23, 2026 23:22
Destroyed
|
🚅 Deployed to the secure-exec-pr-118 environment in rivet-frontend
🚅 Deployed to the secure-exec-pr-118 environment in secure-exec
|
Member
|
Closing for now — holding the SidecarProcess.onStderr forwarding work; not landing this on main at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with agent-os
abc/fixes-1.Adds
SidecarProcess.onStderr(handler)so embedders can stream the sidecar's stderr live — the sidecar re-emits the in-VM agent adapter's stderr on this channel (taggedACP adapter stderr), but it was previously only buffered and surfaced on process exit. Delegates to the protocol client's already-public child stderr; coexists with the internal exit-diagnostics buffering.(Also contains the http2 default-port coercion commit, whose content already landed on
mainvia #117; this PR's net new change isonStderr.)