Repository navigation
Conversation
|
I'd rather see this imported like this, which is how I would write it: use ringbahn::drive::demo;
use ringbahn::event::Read;
use ringbahn::Submission; |
|
(Wall of text. Perhaps I've put a lot more thought to this than it needs. It had me thinking, though, and I went into the blog-writing mindset 😖. Perhaps I enjoyed digesting the nuances at play a bit too much 😅) I agree in the context of writing production/personal code. Normally I would do the same. For this PR, I had a different context in mind when I made this style choice. I was reading the example as first-look at how to use this library, looking to get a big-picture understanding. I think this difference in context is key. To illustrate how this motivated my decisions:
I have a lot of respect for your approach to subjective matters. If the following arguments are constructive, your consideration of them would be appreciated. I can certainly see that your approach holds merit in the general case of example code, particularly in that it's consistent with good production style. For this example, however, I argue we have an edge case and that warrants this style adjustment.
The choice is inescapably of an opinionated and subjective nature. I've read some of the your write-ups on such issues (and re-read Not Explicit), and I have a lot of respect for how your mind works with them. I'll be satisfied whichever choice you make. Say the word and I'll change the PR accordingly. ...seems like I let myself go on that. Don't read into it as a sign of how strongly I feel about it. It's as much an opportunity for me to practice articulating my thoughts as it is to add my thoughts to the discussion. |
This PR is a minor edit of PR #23 . Glob imports can add an element of cognitive overhead to understanding library usage. I chose
use ringbahn as rb;so as to keep it concise and in the spirit of the original PR.