Skip to content

Update net_asyncio.py#267

Merged
lsabi merged 2 commits intorethinkdb:masterfrom
dpineiden:patch-1
Oct 12, 2023
Merged

Update net_asyncio.py#267
lsabi merged 2 commits intorethinkdb:masterfrom
dpineiden:patch-1

Conversation

@dpineiden
Copy link
Copy Markdown
Contributor

Reason for the change
If applicable, link the related issue/bug report or write down in few sentences the motivation.

Description
A clear and concise description of what did you changed and why.

Code examples
If applicable, add code examples to help explain your changes.

Checklist

References
Anything else related to the change e.g. documentations, RFCs, etc.

At the python doc, a closing of async socket has that two lines:

self.streamwriter.close()
await self.streamwriter.wait_closed()

In my case, despite closing connections, those are not closing and the number of open cons are increasing (without second line)

@dpineiden
Copy link
Copy Markdown
Contributor Author

@srh srh closed this Oct 11, 2023
@srh srh reopened this Oct 11, 2023
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy bot commented Oct 11, 2023

Code Climate has analyzed commit 975e22a and detected 0 issues on this pull request.

View more on Code Climate.

@srh
Copy link
Copy Markdown
Contributor

srh commented Oct 11, 2023

Sorry about the needless notification -- I unclosed because I realized my issue or PR maintenance would step on the real maintainers' toes. And there is a legitimate wait_closed change...

lsabi
lsabi previously approved these changes Oct 12, 2023
@lsabi lsabi merged commit 410880d into rethinkdb:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants