fix: git URI matching for GitHub fallback#30
Merged
wei merged 4 commits intorepo-sync:masterfrom Sep 3, 2020
notorious-gay:enhancement-git-uri-check
Merged
fix: git URI matching for GitHub fallback#30wei merged 4 commits intorepo-sync:masterfrom notorious-gay:enhancement-git-uri-check
wei merged 4 commits intorepo-sync:masterfrom
notorious-gay:enhancement-git-uri-check
Conversation
This allows the user to use this action to pull a glitch.com repo to github as they too do not use the .git suffix 👍 This has been tested to work with the following styles: https://user@api.glitch.com/git/project git@github.com:repo-sync/github-sync.git http://user@api.glitch.com/git/project repo-sync/github-sync ssh://user@host.xz:port/path/to/repo.git/ ssh://user@host.xz/path/to/repo.git/ ssh://host.xz:port/path/to/repo.git/ ssh://host.xz/path/to/repo.git/ ssh://user@host.xz/path/to/repo.git/ ssh://host.xz/path/to/repo.git/ ssh://user@host.xz/~user/path/to/repo.git/ ssh://host.xz/~user/path/to/repo.git/ ssh://user@host.xz/~/path/to/repo.git ssh://host.xz/~/path/to/repo.git user@host.xz:/path/to/repo.git/ host.xz:/path/to/repo.git/ user@host.xz:~user/path/to/repo.git/ host.xz:~user/path/to/repo.git/ user@host.xz:path/to/repo.git host.xz:path/to/repo.git rsync://host.xz/path/to/repo.git/ git://host.xz/path/to/repo.git/ git://host.xz/~user/path/to/repo.git/ http://host.xz/path/to/repo.git/ https://host.xz/path/to/repo.git/ https://user@host.xz/path/to/repo https://user@host.xz/path/to/repo.git
Member
|
Wow thanks so much for the PR! Instead of adding Also updated the regex a bit to cover something like If you don't mind, could you pls review my change and perform some quick tests with the url examples you provided above? |
Contributor
Author
|
No worries, I'll give this a try and get back to you! |
Contributor
Author
|
All passed and running correctly on my test repo, looks like we're good to go! 🎉 |
Member
|
@all-contributors please add @GlitchShtick for bugs |
Contributor
|
I've put up a pull request to add @GlitchShtick! 🎉 |
Member
|
@GlitchShtick It's been released and accessible via |
Contributor
Author
|
No worries at all! 😁 |
shakti-garg
added a commit
to shakti-garg/git-sync
that referenced
this pull request
Oct 27, 2020
Regex derived from repo-sync/github-sync#30
wei
pushed a commit
to wei/git-sync
that referenced
this pull request
Nov 3, 2020
* Update grep regex for precise filtering of urls * update source and destination repo regex Regex derived from repo-sync/github-sync#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to use this action to pull a glitch.com repo to GitHub as they too do not use the .git suffix 👍
(As well as many other origins thanks to @wei's suggestion!)
After wrangling with docker and GitHub not running the action correctly I've got this working, please note the following additional changes had to be made to get the regex to work:
Please let me know if you have any questions or suggestions 😄
This change has been tested to work with the following URI's: