Skip to content

open-all-conversations - Fix multiple conversations detection #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SunsetTechuila wants to merge 8 commits into
base: main
Choose a base branch
from
+22 −18
Draft

open-all-conversations - Fix multiple conversations detection #9506

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08255c8
`open-all-conversations` - Fix multiple conversations detection
SunsetTechuila May 17, 2026
6679bcb
Merge branch 'main' into open-all-conv
SunsetTechuila May 20, 2026
e673cf0
comments and todos
SunsetTechuila May 20, 2026
cf3a635
fix selector
SunsetTechuila May 20, 2026
15bd1e3
todos
SunsetTechuila May 20, 2026
348d795
fix pr counter selector
SunsetTechuila May 20, 2026
41ae084
revert to `multipleConversationsSelector`
SunsetTechuila May 20, 2026
0bfbe74
refactor
SunsetTechuila May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions source/features/open-all-conversations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ import observe from '../helpers/selector-observer.js';

function onButtonClick(): void {
const links = $$([
// Issue list
'a[data-testid="issue-pr-title-link"]',
'a.h4.js-navigation-open', // TODO: Pre-React selector; Drop in 2026
// PR list -- TODO: Drop after global and repo PR lists become exclusively React-based
'a.h4.js-navigation-open',
]);

if (links.length > 25) {
Expand All @@ -20,7 +22,9 @@ function onButtonClick(): void {

const selectedLinks = links.filter(link =>
$closestOptional([
'.js-issue-row.selected', // TODO: Pre-React selector; Drop in 2026
// PR list -- TODO: Drop after global and repo PR lists become exclusively React-based
'.js-issue-row.selected',
// Issue list
'[aria-label^="Selected"]',
], link),
);
Expand All @@ -33,19 +37,25 @@ function onButtonClick(): void {
void openTabs(urls);
}

const multipleConversationsSelector = [
'.js-issue-row + .js-issue-row', // TODO: Pre-React selector; Drop in 2026
'[role="list"] > div:nth-child(2) > [class^="IssueRow"]',
] as const;

async function hasMoreThanOneConversation(): Promise<boolean> {
return Boolean(await elementReady(multipleConversationsSelector, {waitForChildren: false}));
const list = await elementReady(
[
// Issue list
'ul[data-listview-component="items-list"]',
// PR list -- TODO: Drop after global and repo PR lists become exclusively React-based
'#js-issues-toolbar ~ div > div',
],
{stopOnDomReady: false, waitForChildren: false},
);
return !pageDetect.isBlank() && list!.childElementCount > 1;
}

function add(anchor: HTMLElement): void {
const isLegacy = $closestOptional('.table-list-header-toggle', anchor);
const isSelected = $closestOptional([
'.table-list-triage', // TODO: Pre-React selector; Drop in 2026
// PR list -- TODO: Drop after global and repo PR lists become exclusively React-based
'.table-list-triage',
// Issue list
'[aria-label="Bulk actions"]',
], anchor);
const classes = isLegacy
Expand All @@ -68,7 +78,9 @@ function add(anchor: HTMLElement): void {
async function init(signal: AbortSignal): Promise<void | false> {
observe(
[
'.table-list-header-toggle:not(.states)', // TODO: Pre-React selector; Drop in 2026
// PR list -- TODO: Drop after global and repo PR lists become exclusively React-based
'.table-list-header-toggle:not(.states)',
// Issue list
'[aria-label="Bulk actions"] > :first-child',
'[aria-label="Actions"] > :first-child',
],
Expand All @@ -85,14 +97,6 @@ void features.add(import.meta.url, {
include: [
pageDetect.isIssueOrPRList,
],
exclude: [
pageDetect.isGlobalIssueOrPRList,
],
init,
}, {
include: [
pageDetect.isGlobalIssueOrPRList,
],
init,
});

Expand Down
Loading