Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dec1973. Configure here.
Collaborator
Author
|
merging; new tests only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-only changes with no production library modifications; CI may skip one environment combination until the upstream RediSearch bug is fixed.
Overview
Adds
TestSearchLimitOffsetto exerciseFT.SEARCHwithQuery.Limit(20, 10)(offset 20, count 10) on a sorted numeric index and assert 30 total hits with 10 documents returned, tied to investigating #508.The test runs across
EndpointsFixture.Env.AllEnvironments, applies existingSkipClusterPre8, and skips cluster + RESP3 when RediSearch ignores the LIMIT offset (documented as RediSearch#10369, server-side—not the client).Also replaces
log.WriteLinewith the baseLog(...)helper in several Alter index info diagnostics.Reviewed by Cursor Bugbot for commit dec1973. Bugbot is set up for automated code reviews on this repo. Configure here.