Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redis/NRedisStack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: redis/NRedisStack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: marc/INITBYDIM
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 11 files changed
  • 1 contributor

Commits on Sep 14, 2026

  1. CMS: add CELL_SIZE support, fix CMS.INFO field name, cover negative I… 

    …NCRBY

- CMS.INITBYDIM/INITBYPROB take an optional cellSize (1, 2, 4, or 8 bytes)
  argument, sent as CELL_SIZE <n>.
- CmsInformation.CellSize now parses the "cell_size" field correctly;
  it previously looked for "cell size" (with a space) and always read -1.
- Add regression tests for CELL_SIZE and for negative CMS.INCRBY
  increments (already passed through unchanged, now covered).
    @mgravell
    mgravell committed Sep 14, 2026
    Configuration menu
    Copy the full SHA
    e940b7c View commit details
    Browse the repository at this point in the history

  2. CMS: avoid binary break by adding CELL_SIZE as new overloads 

    InitByDim/InitByProb (and their Async/interface/builder counterparts)
keep their original 3-arg signatures; CELL_SIZE support is added via
new 4-arg overloads instead of an extra optional parameter on the
existing methods, so the existing compiled signatures are unchanged.
    @mgravell
    mgravell committed Sep 14, 2026
    Configuration menu
    Copy the full SHA
    8ce6301 View commit details
    Browse the repository at this point in the history

  3. CMS: gate CELL_SIZE/negative-INCRBY tests to 8.12+, add 8.12 CI matri… 

    …x row

- CMS.INITBYDIM/INITBYPROB CELL_SIZE tests and CMS.INCRBY negative-increment
  tests are SkipIfRedisTheory-gated at 8.12.0, since older servers reject
  the CELL_SIZE argument (wrong number of arguments) and negative increments.
- Add tests/dockers/.env.v8.12, pinned to an unstable preview image pending
  an official 8.12 release, and add "8.12" to both the PR/push and nightly
  redis-version matrices in integration.yml.
    @mgravell
    mgravell committed Sep 14, 2026
    Configuration menu
    Copy the full SHA
    8f65407 View commit details
    Browse the repository at this point in the history
Loading