Static closure rule ignores arguments with $this binding #7721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 6, 2025
src/NodeAnalyzer/CallLikeExpectsThisBindedClosureArgsAnalyzer.php
Outdated
Show resolved
Hide resolved
TomasVotruba
reviewed
Dec 6, 2025
rules-tests/CodingStyle/Rector/Closure/StaticClosureRector/Source/functions.php
Show resolved
Hide resolved
TomasVotruba
reviewed
Dec 6, 2025
1310b07 to
91e3be0
Compare
samsonasik
reviewed
Dec 7, 2025
src/NodeAnalyzer/CallLikeExpectsThisBindedClosureArgsAnalyzer.php
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Dec 7, 2025
samsonasik
reviewed
Dec 8, 2025
…e-improved # Conflicts: # src/DependencyInjection/LazyContainerFactory.php # src/NodeTypeResolver/Node/AttributeKey.php # src/PhpParser/NodeVisitor/CallLikeThisBoundClosureArgsNodeVisitor.php
…e-improved # Conflicts: # rules/CodingStyle/Guard/ArrowFunctionAndClosureFirstClassCallableGuard.php
samsonasik
reviewed
Dec 14, 2025
| public function getArgsUsingThisBoundClosure(CallLike $callLike): array | ||
| { | ||
| $args = []; | ||
| $reflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($callLike); |
Member
There was a problem hiding this comment.
move this reflection get before it usage
samsonasik
reviewed
Dec 14, 2025
Comment on lines
+44
to
+45
| $parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select($reflection, $callLike, $scope); | ||
| $parameters = $parametersAcceptor->getParameters(); |
Member
There was a problem hiding this comment.
I think verify if there is Closure as Arg first is better to avoid possible reflection check:
$args = $callLike->getArgs();
$hasClosureArg = (bool) array_filter($args, fn (Arg $arg): bool => $arg->value instanceof Closure);
if (! $hasClosureArg) {
return null;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CallLikeExpectsThisBindedClosureArgsAnalyzerwhich allows the detection of the@param-closure-this.@param-closure-thisand then skip these closuresWhy
Often there's a few scenarios where the static closure rule causes problems and starts to add the keyword where it will break code because it's being used as a argument for a parameter which will be later bound to an object. This can't be done if the closure is static and causes a runtime error.
This happens quite a lot in Laravel projects. Example issues driftingly/rector-laravel#102
Notes
I had to use
method.notFoundto silence PHPStan. I don't know why this is the case as the code works but something is up with PHPStan.I also created a new analyser to make this work but I'm happy to take this method and put it into a pre-existing one if adding a new one seems pointless.