Fix trailing line-block spacing in table cells - #1702
Open
Neallin-917 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1701.
Reset bottom margin only on a line block that is the direct last child of a
table header or data cell. Preserve spacing between blocks and outside tables,
and leave font size and line height unchanged. Add a demo regression covering
headers, stub columns, nested lines and blocks followed by another paragraph.
The checked-in CSS was regenerated with the existing Node 14.21.3,
node-sass 4.14.1 and Webpack 4 toolchain; the lockfile is unchanged.
Validation
npm ci --no-audit --no-fund,node bin/preinstall.js,npm run buildpassedin an isolated Node 14 container.
passed and demo documentation built successfully with the new assets.
24 combinations passed geometry assertions. Final blocks have 0px bottom
margin; intermediate/outside blocks retain 24px; nested bottom gap is 0px.
git diff --checkpassed.Firefox and Sphinx development-head were not tested. Existing intentional
invalid-reference demo diagnostics and build-tool deprecation warnings remain.
AI assistance: implemented, tested and reviewed with OpenAI Codex. No claim of
manual human review is implied.