fserrors: make http2 "server sent GOAWAY" a retriable error - fixes #9664 - #9693
Merged
Merged
Conversation
…clone#9664 When an HTTP/2 server retires a connection with GOAWAY after it has already sent successful response headers, Go's http2 transport fails the read of the response body with http2: server sent GOAWAY and closed the connection; LastStreamID=..., ErrCode=NO_ERROR, debug="" This was not recognised as a retriable networking error, so a transient connection retirement aborted the whole command instead of consuming a low level retry. It was reported against a large S3 check, where an interrupted ListObjectsV2 page made rclone report destination objects as missing and exit unsuccessfully. The concrete error type is unexported by net/http, so match on the message as we already do for the other http2 transport errors.
ncw
approved these changes
Jul 29, 2026
ncw
left a comment
Member
There was a problem hiding this comment.
It is annoying that the error isn't exported properly but I shall merge this as it will fix the problem!
Thank you :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an HTTP/2 server retires a connection with GOAWAY after it has already sent successful response headers, Go's http2 transport fails the read of the response body with
This was not recognised as a retriable networking error, so a transient connection retirement aborted the whole command instead of consuming a low level retry. It was reported against a large S3 check, where an interrupted ListObjectsV2 page made rclone report destination objects as missing and exit unsuccessfully.
The concrete error type is unexported by net/http, so match on the message as we already do for the other http2 transport errors.
What does this change do?
Linked issue
Fixes #9664
For new or changed backends
Checklist
test_allpasses for this backend and if submitting a new backend can provide a test account for the integration tester - see CONTRIBUTING.md.