Conversation
somaz94
marked this pull request as ready for review
June 23, 2026 01:36
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 8e3ebfd. Configure here.
Signed-off-by: somaz <genius5711@gmail.com>
…luster chart Signed-off-by: somaz <genius5711@gmail.com>
somaz94
force-pushed
the
feat/ray-cluster-pdb
branch
from
July 22, 2026 03:23
1122cee to
b77adb9
Compare
Author
|
Gentle ping. This adds an optional PodDisruptionBudget to the ray-cluster chart, off by default. CI is green. Happy to adjust the defaults or the values layout if you would prefer something different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
ray-clusterHelm chart has no way to declare aPodDisruptionBudgetfor the RayCluster pods. Without a PDB, voluntary disruptions — node drains during maintenance, cluster-autoscaler scale-down — can evict the Ray head and/or all workers at once, disrupting running jobs.This adds an opt-in
PodDisruptionBudgetto the chart, disabled by default so existing installs are unaffected:podDisruptionBudgetblock invalues.yaml(enabled: falseby default), supportingminAvailable(default1) /maxUnavailable, plusselectorLabelsto extend the selector.templates/poddisruptionbudget.yaml, guarded by{{- if .Values.podDisruptionBudget.enabled }}, renderingpolicy/v1. The selector targets the operator-managedray.io/clusterlabel so it reliably matches every pod of this RayCluster;minAvailabletakes precedence when both knobs are set.versionbumped1.1.0→1.2.0.helm-unittestsuitetests/poddisruptionbudget_test.yamlcovering disabled-default, enabled,maxUnavailable, precedence, andselectorLabelsmerge.Verified locally:
helm lint,helm unittest --strict(109 tests pass), andct lint(version increment validated) — matching the chart CI in.github/workflows/helm.yaml.Related issue number
N/A — net-new opt-in feature.
Checks
helm unittest --strict, 5 new PDB cases)helm templaterendered for PDB enabled / disabled / custommaxUnavailable+selectorLabels;helm lint+ct lintpass)