This repository was archived by the owner on May 14, 2021. It is now read-only.
Include ScanConfig attributes with defaults#9
Merged
Conversation
Added representation for ScanConfig attributes in CreateFromXML Added representation for said elements in the AsXML output
Contributor
|
I created a PR on your branch to simplify the defaults: https://github.com/scottjpack/nexpose-client-python/pull/1 Once you merge it (or just carry over the changes manually) and everything looks good, I'll go ahead and merge this PR. |
Contributor
|
On a side note, for your example you should instead use Range for IP addresses, e.g. site_cfg.hosts.append(nexpose_site.Range("192.168.0.100", None)) |
Set SiteConfig defaults on init instead of save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added representation for ScanConfig attributes in CreateFromXML
Added representation for said elements in the AsXML output
Added defaults to attributes based on the original hardcoded-values.
This addresses a problem we were having with saving modified SiteConfigurations. Also mentioned in #6
ScanConfig attributes were not previously being saved as part of the SiteConfiguration item. This change pulls in the configID, configVersion, engineID, name, and templateID in the CreateCromXML method. These attributes were previously statically defined in the AsXML method, but were not being attached to the new element (previous line 132).
You can test using the following snippet: