Final check on regression data, tidy up tests#17
Merged
Conversation
8998244 to
3442d24
Compare
3442d24 to
d6a1338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalises the regression tests for the full release, including the regression test data for Windows and Linux. macOS regression data is not added at this stage, as it would be better to host the regression data elsewhere before adding macOS as not to bloat the repo. macOS was checked manually as part of this PR.
Also includes a small bug fix revealed when plotting a very small number of datapoints in a line plot, related to the calculation of the hover pop up value.