Skip to content

Add link to git-diff of selected versions#587

Merged
nbibler merged 2 commits intorailsdiff:mainfrom
airblade:main
Feb 17, 2025
Merged

Add link to git-diff of selected versions#587
nbibler merged 2 commits intorailsdiff:mainfrom
airblade:main

Conversation

@airblade
Copy link
Contributor

@airblade airblade commented Feb 5, 2025

See #496.

@jswanner jswanner requested a review from nbibler February 5, 2025 19:09
@airblade
Copy link
Contributor Author

airblade commented Feb 6, 2025

Test failure is unrelated. My own test passes.

@nbibler
Copy link
Member

nbibler commented Feb 6, 2025

@airblade: Thanks for the submission! I'll try to take a look at this tonight and get back to you. 😄

@airblade
Copy link
Contributor Author

Hi @nbibler! Have you had a chance to look at this? 😃

@nbibler
Copy link
Member

nbibler commented Feb 17, 2025

Ack! 😞 I have not…

@nbibler nbibler merged commit d367fc6 into railsdiff:main Feb 17, 2025
1 of 2 checks passed
@nbibler
Copy link
Member

nbibler commented Feb 17, 2025

I'll have to take a look at the failing CI tests… it looks like ESLint is incorrectly erring on node_modules files. Also, everything is a few years out of date... so there's that. ;)

Thank you for the PR, sorry for the delay!

@airblade
Copy link
Contributor Author

You're welcome! Thank you for taking the time to deal with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants