fix: link_pyqt.py excluding QtWebProcess.exe files and QtWebEngine resources on Windows - #8989
Open
qqueeeeee wants to merge 1 commit into
Open
fix: link_pyqt.py excluding QtWebProcess.exe files and QtWebEngine resources on Windows#8989qqueeeeee wants to merge 1 commit into
qqueeeeee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
scripts/link_pyqt.pyis supposed to copy the system-wide PyQt installation into the tox virtualenv (via get_ignored_files / copy_or_link). However, .exe files are never actually copied, because needed_exts never correctly matches the.exeextension. This means QtWebEngineProcess.exe and the resources/ directory never get linked into the tox venv on Windows, which breaks any test or usage that spins up QtWebEngine, you get errors about the WebEngine process failing to start, or missing resource files, with no indication that the cause is an incomplete copy.So, the script now has the required file extension additions (.exe, .pak, .dat, .bin) which lets it fully copy the required files like the
QtWebEngineProcess.exeinto the .tox directory.