Draft
Fix data dictionary golden-file mismatch caused by incomplete underscore rule in XSLT name conversion#95
Conversation
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…tion Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…arations Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…-stylesheets Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
….xml Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…efore uppercase Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrjohn
September 3, 2026 01:41
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataDictionaryGoldenFileTestfailed with an assertion error atFIXLatest.xmlline 10734, indicating the XSLT-based data dictionary generator (introduced to replace the JAXB implementation) no longer produced output matching the golden fixture.Root cause
qfj:precedeCapsWithUnderscoreincommon.xsl— the XSLT equivalent of the original JavatoConstantName— only inserted an underscore between a lowercase letter and a following uppercase letter. The Java version inserts an underscore before any uppercase letter not preceded by another uppercase letter, including when preceded by a digit. This divergence produced incorrect enum-value descriptions wherever a name had a digit immediately before an uppercase letter:Verified by comparing the new XSLT generator's output against the original JAXB generator on the current
OrchestraFIXLatest.xml: aside from this bug, the two implementations produce byte-for-byte identical output, confirming the golden fixture — not the generator logic — needed to reflect the corrected behavior.Changes
common.xsl: added a second regex pass toprecedeCapsWithUnderscorefor digit→uppercase transitions, matching the Java algorithm exactly.golden/dictionary/FIXLatest.xml: regenerated from the corrected generator output.Out of scope
quickfix.OrchestraGoldenFileTest(Java code golden test) still fails — its golden.javasources were never regenerated afterOrchestraFIXLatest.xmlwas bumped to EP309. This is a separate, pre-existing fixture-staleness issue, unrelated to the XSLT naming bug fixed here.