537 pointer can get stuck on "loading" (use onCleanup hooks to restore pointer)#536
Open
martinherrerias wants to merge 1 commit into
Open
537 pointer can get stuck on "loading" (use onCleanup hooks to restore pointer)#536martinherrerias wants to merge 1 commit into
martinherrerias wants to merge 1 commit into
Conversation
There are other uses of set(H,'pointer',...) which I haven't touched: - External/NIfTI_20140122/* - code seems unused? - External/imtool3D* - more complex use, seems better managed
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Issue, with steps to reproduce: #537
There are several places in the code that use the pattern:
If there's an error in the middle, the pointer restore action is never reached, and the pointer gets stuck in the watch icon. The user gets the feeling that the app is still processing a command, but it is actually waiting for a new user action.
Approach
Replaced some (see note below) of these occurrences with the pattern:
The
onCleanuphook is executed upon deletion of therestore_object, regardless of whether this is due to an error, or successful execution of the rest of the code in the scope.Note
There are other uses of
set(H,'pointer',...)which I haven't touched:External/NIfTI_20140122/*- mostly aroundview_nii, which seems unused?External/imtool3D*- more complex use of the pointer, so it requires more careful analysis (also seems better managed)Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications